mirror of
https://github.com/barkeser2002/offline-db.git
synced 2026-09-25 00:59:54 +03:00
Barış Keserandgoogle-labs-jules[bot]
a2e3f28344
- Fixed syntax error in `users/tests/test_genre_savant_badge.py` - Implemented `users/tests/test_chat_badges.py` - Added tests for `BadgeStrategy` base class methods. - Added extensive `users/tests/test_badge_system_remaining.py` tests that covered all remaining cache hit, miss, and logic code branches for `ReviewBadgeStrategy`, `WatchTimeBadgeStrategy`, `AccountBadgeStrategy`, `ConsistencyBadgeStrategy`, `CompletionBadgeStrategy`, `CommunityBadgeStrategy`, `GenreBadgeStrategy`, and `SpecificGenreBadgeStrategy`. - Cleaned up unreachable code in `GenreBadgeStrategy.get_anime_ids()` that prevented reaching 100% test coverage. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
10 lines
1.1 KiB
Markdown
10 lines
1.1 KiB
Markdown
1. **Analyze Code Coverage**: Discovered that `.jules/development-plan.md` requested 100% unit test coverage for `users/badge_system.py` logic. Checked the current coverage to verify the missing lines.
|
|
2. **Add missing unit tests**:
|
|
- Fix the syntax error in `users/tests/test_genre_savant_badge.py`.
|
|
- Add `users/tests/test_chat_badges.py` to cover `ChatBadgeStrategy`.
|
|
- Add `users/tests/test_badge_strategy_base.py` for abstract base class methods.
|
|
- Add `users/tests/test_badge_system_remaining.py` to cover code branches for `ReviewBadgeStrategy`, `WatchTimeBadgeStrategy`, `AccountBadgeStrategy`, cache hits and misses for `ConsistencyBadgeStrategy`, `CompletionBadgeStrategy`, `CommunityBadgeStrategy`, `GenreBadgeStrategy`, and `SpecificGenreBadgeStrategy`.
|
|
3. **Verify tests pass**: Run `pytest --cov=users.badge_system --cov-report=term-missing` again to verify 100% test coverage.
|
|
4. **Complete pre-commit steps**: Complete pre-commit steps to ensure proper testing, verification, review, and reflection are done.
|
|
5. **Commit and Submit**: Push the branch for review.
|